RE: [sv-bc] MERGE REVIEW draft 2: Chapter 22

Hi,


> 22.1 "can represent functional" ??

[SB] "can represent function"


> 22.1.1 "The port directions and sizes of the module" vs. "The type of
> data passed through each port"  Isn't the size of a port an aspect of
> its type?

[SB] The phrase "The port directions and sizes of the module" is awkward
as the directions and sizes are of the ports, not directly of the
module. If the next item can be "The type of data passed through each
port", then this can be "The direction and size of each port".
(or 'direction' if 'size' is omitted).


> 22.1.3 "Port declarations can be based on parameter declarations. The
> parameter type of parameters can be redefined for each instance of a
> module, providing a means of customizing the characteristics of each
> instance of a module."  OK, but it's not possible for the
> characteristics of the instances in an array of instances to differ
> from
> each other, is it?  I think they can only be customized in bulk.

[SB] We discussed this in Mantis 1254.

Also, I find "The parameter type of parameters" awkward. I prefer simply
"Parameter types" or "The type of a parameter".


> 
> 22.2 "A module can be used (instantiated) in two ways"  Could we
> choose
> 'used' or 'instantiated' and get rid of the parenthetical comment?
> 
[SB] Regarding the sentence, "Top-level modules are implicitly
instantiated (see 22.2.1)," see Mantis 1489. Such a sentence needs to
say that the implicit instance name is the same as the module name. 

The sentence also needs to refer back to 3.7 ("A design block that is
elaborated but not instantiated becomes a top-level hierarchy block.")
to define what a top-level module is. 

Note that 1364 defines a top-level module differently: "Top-level
modules are modules that are included in the source text, but do not
appear in any module instantiation statement, as described in 12.1.2.
This applies even if the module instantiation appears in a generate
block that is not itself instantiated (see 12.4)."

Note that 3.7 says, "A design block that is elaborated but not
instantiated becomes a top-level hierarchy block." 25.1 says, "Any
uninstantiated module is at the top level." Both of these imply
non-instantiation, not implicit instantiation.

"Top level" should be consistently hyphenated.

Shalom

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.